feat(www): enable providers to send custom error responses via the dynamic key #1830
+24
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1830 +/- ##
======================================
- Coverage 32% 32% -1%
======================================
Files 45 45
Lines 2610 2620 +10
Branches 337 340 +3
======================================
+ Hits 859 860 +1
- Misses 1751 1760 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
daniellacosse
changed the title
daniellacosse
added
needs UX
needs test
|
We need to better understand the trade-offs between the different approaches, which also included a client response and a Client API. There are also open questions regarding what format we should use, and what the UI should look like, but they can be decoupled from the chosen approach. |
daniellacosse
changed the title
daniellacosse
changed the title
daniellacosse
changed the title
fortuna
requested changes
Mar 7, 2024
src/www/app/outline_server_repository/access_key_serialization.ts
Outdated
Show resolved
Hide resolved
src/www/app/outline_server_repository/access_key_serialization.ts
Outdated
Show resolved
Hide resolved
src/www/views/servers_view/server_list_item/server_card/index.ts
Outdated
Show resolved
Hide resolved
fortuna
requested changes
Mar 11, 2024
src/www/app/outline_server_repository/access_key_serialization.ts
Outdated
Show resolved
Hide resolved
src/www/app/outline_server_repository/access_key_serialization.ts
Outdated
Show resolved
Hide resolved
fortuna
reviewed
Mar 11, 2024
src/www/app/outline_server_repository/access_key_serialization.ts
Outdated
Show resolved
Hide resolved
fortuna
approved these changes
Mar 12, 2024
|
We also need to think about communicating the new feature in the next release, and perhaps add that to the wiki. |
fortuna
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables service providers to return an error object to inform the end user about something wrong with their dynamic key or server connection. Service providers could then volunteer contact information via this error message.
